linux-kernel - Re: [PATCH 3/3] ASoC: dt-bindings: wlf,wm8782: Add max-rate property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Aug 2023 14:59:35 +0100
From:   Mark Brown <broonie@...nel.org>
To:     John Watts <contact@...kia.org>
Cc:     alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, patches@...nsource.cirrus.com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] ASoC: dt-bindings: wlf,wm8782: Add max-rate property

On Fri, Aug 11, 2023 at 08:49:30AM +1000, John Watts wrote:

> + - max-rate    : max supported audio rate configured by FSAMPEN pin, defaults to 48000

This seems like a cumbersome and error prone way to configure this - why
not just have the binding specify the state of the pin?  That's just a
boolean high/low whereas this requires getting the rate right and then
having the driver validate it.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)