[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZNZFB2-kBrpnMSn1@titan>
Date: Sat, 12 Aug 2023 00:26:15 +1000
From: John Watts <contact@...kia.org>
To: Mark Brown <broonie@...nel.org>
Cc: alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, patches@...nsource.cirrus.com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] ASoC: dt-bindings: wlf,wm8782: Add max-rate property
On Fri, Aug 11, 2023 at 02:59:35PM +0100, Mark Brown wrote:
> On Fri, Aug 11, 2023 at 08:49:30AM +1000, John Watts wrote:
>
> > + - max-rate : max supported audio rate configured by FSAMPEN pin, defaults to 48000
>
> This seems like a cumbersome and error prone way to configure this - why
> not just have the binding specify the state of the pin? That's just a
> boolean high/low whereas this requires getting the rate right and then
> having the driver validate it.
Hi there, the pin is tristate, Z, 0 and 1. How would that be represented?
John.
Powered by blists - more mailing lists