linux-kernel - Re: [PATCH] Multi-gen LRU: skip CMA pages when they are not eligible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 12 Aug 2023 10:39:13 +0530
From:   Charan Teja Kalla <quic_charante@...cinc.com>
To:     Yu Zhao <yuzhao@...gle.com>
CC:     David Hildenbrand <david@...hat.com>, <akpm@...ux-foundation.org>,
        <zhaoyang.huang@...soc.com>, <surenb@...gle.com>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        Kalesh Singh <kaleshsingh@...gle.com>
Subject: Re: [PATCH] Multi-gen LRU: skip CMA pages when they are not eligible

On 8/9/2023 10:39 PM, Yu Zhao wrote:
>> On Wed, Aug 9, 2023 at 7:00 AM David Hildenbrand <david@...hat.com> wrote:
>>> On 09.08.23 10:05, Charan Teja Kalla wrote:
>>>> This patch is based on the commit 5da226dbfce3("mm: skip CMA pages when
>>>> they are not available") which skips cma pages reclaim when they are not
>>>> eligible for the current allocation context. In mglru, such pages are
>>>> added to the tail of the immediate generation to maintain better LRU
>>>> order, which is unlike the case of conventional LRU where such pages are
>>>> directly added to the head of the LRU list(akin to adding to head of the
>>>> youngest generation in mglru).
>>>>
>>>> No observable issue without this patch on MGLRU, but logically it make
>>>> sense to skip the CMA page reclaim when those pages can't be satisfied
>>>> for the current allocation context.
>>>>
>>>> Signed-off-by: Charan Teja Kalla <quic_charante@...cinc.com>
>> Reviewed-by: Kalesh Singh <kaleshsingh@...gle.com>
> Thanks, Charan! Do we need a "Fixes" tag?
I think the below tag matches.

Fixes: ac35a4902374 ("mm: multi-gen LRU: minimal implementation")
>