linux-kernel - Re: [PATCH v2] tracing/eprobe: Iterate trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230812142019.06cb38b56287b0f068e8164f@kernel.org>
Date:   Sat, 12 Aug 2023 14:20:19 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Chuang Wang <nashuiliang@...il.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tracing/eprobe: Iterate trace_eprobe directly

On Fri, 11 Aug 2023 15:45:23 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Fri, 11 Aug 2023 16:12:39 +0800
> Chuang Wang <nashuiliang@...il.com> wrote:
> 
> > +
> > +#define for_each_trace_eprobe_on_trace_probe(ep, _tp) \
> > +	list_for_each_entry(ep, trace_probe_probe_list(_tp), tp.list)
> > +
> 
> As I replied to the other patch, but after this one was sent (sorry, I was
> hyperfocused on my work the last couple of days and was not reading email,
> so my INBOX is a bit full). I really hate the verbosity of that name.
> 
> At a minimum, let's call it:
> 
>   for_each_trace_point_eprobe()

OK, what about "for_each_trace_eprobe_on()"? I would like to clarify

- what type is returned
- not all trace_eprobes, but only on the trace_probe.

Thank you,

> 
> -- Steve


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>