linux-kernel - Re: [PATCH v2 2/3] iio: pressure: bmp280: Use i2c_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <954c859835aed6c41a356fdd999a8be51469eb9e.camel@gmail.com>
Date:   Sun, 13 Aug 2023 21:09:13 +0200
From:   Angel Iglesias <ang.iglesiasg@...il.com>
To:     Biju Das <biju.das.jz@...renesas.com>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH v2 2/3] iio: pressure: bmp280: Use i2c_get_match_data

On Sun, 2023-08-13 at 21:03 +0200, Angel Iglesias wrote:
> Replaces device_get_match_data() and fallback match_id logic by new
> unified helper function i2c_get_match_data().
> 
> Signed-off-by: Angel Iglesias <ang.iglesiasg@...il.com>
> 
> diff --git a/drivers/iio/pressure/bmp280-i2c.c b/drivers/iio/pressure/bmp280-
> i2c.c
> index 693eb1975fdc..34e3bc758493 100644
> --- a/drivers/iio/pressure/bmp280-i2c.c
> +++ b/drivers/iio/pressure/bmp280-i2c.c
> @@ -11,9 +11,7 @@ static int bmp280_i2c_probe(struct i2c_client *client)
>         const struct bmp280_chip_info *chip_info;
>         struct regmap *regmap;
>  
> -       chip_info = device_get_match_data(&client->dev);
> -       if (!chip_info)
> -               chip_info = (const struct bmp280_chip_info *) id->driver_data;
> +       chip_info = i2c_get_match_data(client);
>  
>         regmap = devm_regmap_init_i2c(client, chip_info->regmap_config);
>         if (IS_ERR(regmap)) {

Hi,

I noticed I submitted this change that was also submitted by Biju Das on another
patch:
https://lore.kernel.org/all/20230812175808.236405-1-biju.das.jz@bp.renesas.com/

Should I drop this patch from the series?

Kind regards,
Angel