linux-kernel - Re: [PATCH] thermal: mediatek: auxadc_thermal: removed call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 13 Aug 2023 22:09:20 +0300
From:   Alexandru Ardelean <alex@...uggie.ro>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, rdunlap@...radead.org,
        void0red@...t.edu.cn, daniel@...rotopia.org, bchihi@...libre.com,
        aouledameur@...libre.com, angelogioacchino.delregno@...labora.com,
        matthias.bgg@...il.com, rui.zhang@...el.com, amitk@...nel.org,
        daniel.lezcano@...aro.org, rafael@...nel.org
Subject: Re: [PATCH] thermal: mediatek: auxadc_thermal: removed call to platform_set_drvdata()

On Fri, Aug 11, 2023 at 10:28 PM Andrei Coardos <aboutphysycs@...il.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>

> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
>  drivers/thermal/mediatek/auxadc_thermal.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
> index f59d36de20a0..99a1c35c68e7 100644
> --- a/drivers/thermal/mediatek/auxadc_thermal.c
> +++ b/drivers/thermal/mediatek/auxadc_thermal.c
> @@ -1283,8 +1283,6 @@ static int mtk_thermal_probe(struct platform_device *pdev)
>                         mtk_thermal_init_bank(mt, i, apmixed_phys_base,
>                                               auxadc_phys_base, ctrl_id);
>
> -       platform_set_drvdata(pdev, mt);
> -
>         tzdev = devm_thermal_of_zone_register(&pdev->dev, 0, mt,
>                                               &mtk_thermal_ops);
>         if (IS_ERR(tzdev))
> --
> 2.34.1
>