[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230813212343.245521-1-artem.chernyshev@red-soft.ru>
Date: Mon, 14 Aug 2023 00:23:43 +0300
From: Artem Chernyshev <artem.chernyshev@...-soft.ru>
To: Franky Lin <franky.lin@...adcom.com>
Cc: Artem Chernyshev <artem.chernyshev@...-soft.ru>,
Hante Meuleman <hante.meuleman@...adcom.com>,
Arend van Spriel <aspriel@...il.com>,
Kalle Valo <kvalo@...nel.org>, linux-wireless@...r.kernel.org,
brcm80211-dev-list.pdl@...adcom.com,
SHA-cyfmac-dev-list@...ineon.com, linux-kernel@...r.kernel.org,
lvc-project@...uxtesting.org
Subject: [PATCH] brcm80211: brcmsmac: phy_cmn: Remove unreachable code
Since wlc_phy_txpwr_srom_read_nphy() in wlc_phy_attach_nphy()
can not return false it's impossible to get true value in this
if statement
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Artem Chernyshev <artem.chernyshev@...-soft.ru>
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c
index ccc621b8ed9f..07f83ff5a54a 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c
@@ -551,8 +551,7 @@ wlc_phy_attach(struct shared_phy *sh, struct bcma_device *d11core,
if (!pi->phycal_timer)
goto err;
- if (!wlc_phy_attach_nphy(pi))
- goto err;
+ wlc_phy_attach_nphy(pi);
} else if (ISLCNPHY(pi)) {
if (!wlc_phy_attach_lcnphy(pi))
--
2.37.3
Powered by blists - more mailing lists