linux-kernel - Re: [PATCH v2 1/2] dt-bindings: phy: mediatek,tphy: allow simple nodename pattern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230814-isolating-faceless-72835873207e@spud>
Date:   Mon, 14 Aug 2023 17:19:01 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Eugen Hristev <eugen.hristev@...labora.com>
Cc:     linux-mediatek@...ts.infradead.org, chunfeng.yun@...iatek.com,
        vkoul@...nel.org, kishon@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
        sam.shih@...iatek.com, jieyy.yang@...iatek.com,
        frank-w@...lic-files.de, linux-arm-kernel@...ts.infradead.org,
        linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, chris.obbard@...labora.com,
        kernel@...labora.com
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: mediatek,tphy: allow simple
 nodename pattern

On Mon, Aug 14, 2023 at 12:39:30PM +0300, Eugen Hristev wrote:
> The pattern for the nodename only allows t-phy@... , however, for the case
> when the t-phy has no `reg` and only `ranges` (basically when the t-phy
> is just a parent node), dtc will throw this warning:
> 
> Warning (unit_address_vs_reg): /t-phy@...43000: node has a unit name, but no reg or ranges property
> 
> For a node like this:
> 
> 	sata_phy: t-phy@...43000 {
> 		ranges;
> 
> 		sata_port: sata-phy@...43000 {
> 			reg = <0 0x1a243000 0 0x0100>;
> 		};
> 	};
> 
> it is normal that the parent node 't-phy' would be without any address, as in:
> 
> 	sata_phy: t-phy {
> 		ranges;
> 
> 		sata_port: sata-phy@...43000 {
> 			reg = <0 0x1a243000 0 0x0100>;
> 		};
> 	};
> 
> because being just a holder it does not have its own reg.
> 
> However the binding does not allow such a name for the t-phy, so with this
> patch, making the `@[0-9a-f]+` part optional, such node is possible.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@...labora.com>

This seems reasonable to me, perhaps the lads will scream.
Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

> ---
> Changes in v2:
> - none
>  Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> index 230a17f24966..2bb91542e984 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> @@ -64,7 +64,7 @@ description: |
>  
>  properties:
>    $nodename:
> -    pattern: "^t-phy@[0-9a-f]+$"
> +    pattern: "^t-phy(@[0-9a-f]+)?$"
>  
>    compatible:
>      oneOf:
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)