linux-kernel - Re: [PATCH 6/7] selftests/resctrl: remove ben

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a68c3511-f61e-1405-6dad-93b29fd05e04@intel.com>
Date:   Mon, 14 Aug 2023 10:51:04 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Shuah Khan <skhan@...uxfoundation.org>,
        <linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>,
        Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        <linux-kernel@...r.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@...fujitsu.com>
Subject: Re: [PATCH 6/7] selftests/resctrl: remove ben_count variable

Hi Ilpo,

Just a nitpick ... this patch is standing out among the rest by not
starting the subject with a capital letter.

On 8/8/2023 2:16 AM, Ilpo Järvinen wrote:
> ben_count is only used to write the terminator for the list. It is
> enough to use i from the loop so no need for another variable.
> 
> Remove ben_count variable as it is not needed.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
>  tools/testing/selftests/resctrl/resctrl_tests.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette