linux-kernel - Re: [PATCH] drm/amd/pm: Clean up errors in smu_v11_0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Aug 2023 13:51:46 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Ran Sun <sunran001@...suo.com>
Cc:     alexander.deucher@....com, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in smu_v11_0_pptable.h

Applied.  Thanks!

On Mon, Jul 31, 2023 at 5:22 AM Ran Sun <sunran001@...suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: trailing whitespace
> ERROR: open brace '{' following struct go on the same line
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
>  .../gpu/drm/amd/pm/swsmu/inc/smu_v11_0_pptable.h  | 15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/smu_v11_0_pptable.h b/drivers/gpu/drm/amd/pm/swsmu/inc/smu_v11_0_pptable.h
> index 0116e3d04fad..df7430876e0c 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/inc/smu_v11_0_pptable.h
> +++ b/drivers/gpu/drm/amd/pm/swsmu/inc/smu_v11_0_pptable.h
> @@ -101,8 +101,7 @@ enum SMU_11_0_ODSETTING_ID {
>  };
>  #define SMU_11_0_MAX_ODSETTING    32          //Maximum Number of ODSettings
>
> -struct smu_11_0_overdrive_table
> -{
> +struct smu_11_0_overdrive_table {
>      uint8_t  revision;                                        //Revision = SMU_11_0_PP_OVERDRIVE_VERSION
>      uint8_t  reserve[3];                                      //Zero filled field reserved for future use
>      uint32_t feature_count;                                   //Total number of supported features
> @@ -127,8 +126,7 @@ enum SMU_11_0_PPCLOCK_ID {
>  };
>  #define SMU_11_0_MAX_PPCLOCK      16          //Maximum Number of PP Clocks
>
> -struct smu_11_0_power_saving_clock_table
> -{
> +struct smu_11_0_power_saving_clock_table {
>      uint8_t  revision;                                        //Revision = SMU_11_0_PP_POWERSAVINGCLOCK_VERSION
>      uint8_t  reserve[3];                                      //Zero filled field reserved for future use
>      uint32_t count;                                           //power_saving_clock_count = SMU_11_0_PPCLOCK_COUNT
> @@ -136,8 +134,7 @@ struct smu_11_0_power_saving_clock_table
>      uint32_t min[SMU_11_0_MAX_PPCLOCK];                       //PowerSavingClock Mode Clock Minimum array In MHz
>  };
>
> -struct smu_11_0_powerplay_table
> -{
> +struct smu_11_0_powerplay_table {
>        struct atom_common_table_header header;
>        uint8_t  table_revision;
>        uint16_t table_size;                          //Driver portion table size. The offset to smc_pptable including header size
> @@ -145,14 +142,14 @@ struct smu_11_0_powerplay_table
>        uint32_t golden_revision;
>        uint16_t format_id;
>        uint32_t platform_caps;                       //POWERPLAYABLE::ulPlatformCaps
> -
> +
>        uint8_t  thermal_controller_type;             //one of SMU_11_0_PP_THERMALCONTROLLER
>
>        uint16_t small_power_limit1;
>        uint16_t small_power_limit2;
>        uint16_t boost_power_limit;
> -      uint16_t od_turbo_power_limit;                //Power limit setting for Turbo mode in Performance UI Tuning.
> -      uint16_t od_power_save_power_limit;           //Power limit setting for PowerSave/Optimal mode in Performance UI Tuning.
> +      uint16_t od_turbo_power_limit;                //Power limit setting for Turbo mode in Performance UI Tuning.
> +      uint16_t od_power_save_power_limit;           //Power limit setting for PowerSave/Optimal mode in Performance UI Tuning.
>        uint16_t software_shutdown_temp;
>
>        uint16_t reserve[6];                          //Zero filled field reserved for future use
> --
> 2.17.1
>