linux-kernel - Re: [PATCH] iwlwifi: dbg_ini: fix structure packing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a6b2c18b599e5c2e7cea99fec84a4ecb5092da5.camel@sipsolutions.net>
Date:   Mon, 14 Aug 2023 20:28:06 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Arnd Bergmann <arnd@...nel.org>,
        Gregory Greenman <gregory.greenman@...el.com>,
        Kalle Valo <kvalo@...nel.org>,
        Luca Coelho <luciano.coelho@...el.com>,
        Shahar S Matityahu <shahar.s.matityahu@...el.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Mukesh Sisodiya <mukesh.sisodiya@...el.com>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iwlwifi: dbg_ini: fix structure packing

On Fri, 2023-06-16 at 11:03 +0200, Arnd Bergmann wrote:
> 
> As the original intention was apparently to make the entire structure
> unaligned, mark the innermost members the same way so the union
> becomes packed as well.

Hm. Not sure exactly what you mean by that, but shouldn't we make that
"union { ... } __packed"?

johannes