lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <b29731ef-0a72-402c-846a-b37d86712641@app.fastmail.com>
Date:   Mon, 14 Aug 2023 23:02:19 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Johannes Berg" <johannes@...solutions.net>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Gregory Greenman" <gregory.greenman@...el.com>,
        "Kalle Valo" <kvalo@...nel.org>,
        "Luca Coelho" <luciano.coelho@...el.com>,
        "Shahar S Matityahu" <shahar.s.matityahu@...el.com>
Cc:     "Mukesh Sisodiya" <mukesh.sisodiya@...el.com>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iwlwifi: dbg_ini: fix structure packing

On Mon, Aug 14, 2023, at 20:28, Johannes Berg wrote:
> On Fri, 2023-06-16 at 11:03 +0200, Arnd Bergmann wrote:
>> 
>> As the original intention was apparently to make the entire structure
>> unaligned, mark the innermost members the same way so the union
>> becomes packed as well.
>
> Hm. Not sure exactly what you mean by that, but shouldn't we make that
> "union { ... } __packed"?

Up to you, the effect is the same, as the other two members are already
packed. I generally try to keep the packing to the members that are
actually unaligned, to make the code more efficient, but in this case
the entire structure is unaligned, so it doesn't matter.

      Arnd

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ