[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZNnWkD5pCTAD7jTc@localhost.localdomain>
Date: Mon, 14 Aug 2023 10:24:00 +0300
From: Artem Chernyshev <artem.chernyshev@...-soft.ru>
To: Jonas Gorski <jonas.gorski@...il.com>
Cc: Franky Lin <franky.lin@...adcom.com>,
Hante Meuleman <hante.meuleman@...adcom.com>,
Arend van Spriel <aspriel@...il.com>,
Kalle Valo <kvalo@...nel.org>, linux-wireless@...r.kernel.org,
brcm80211-dev-list.pdl@...adcom.com,
SHA-cyfmac-dev-list@...ineon.com, linux-kernel@...r.kernel.org,
lvc-project@...uxtesting.org
Subject: Re: [PATCH] brcm80211: brcmsmac: phy_cmn: Remove unreachable code
On Mon, Aug 14, 2023 at 09:19:14AM +0200, Jonas Gorski wrote:
> On Sun, 13 Aug 2023 at 23:31, Artem Chernyshev
> <artem.chernyshev@...-soft.ru> wrote:
> >
> > Since wlc_phy_txpwr_srom_read_nphy() in wlc_phy_attach_nphy()
> > can not return false it's impossible to get true value in this
> > if statement
>
> If they can only return true, then maybe their return types should be
> changed to void as well? No point in returning a value when the only
> caller is ignoring it.
>
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Signed-off-by: Artem Chernyshev <artem.chernyshev@...-soft.ru>
>
> Regards,
> Jonas
True that. I'll make those changes in v2.
Thank you,
Artem
Powered by blists - more mailing lists