linux-kernel - Re: [PATCH] watchdog: simatic: add PCI dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1834eee9-3fbd-4bea-9e22-960ca993303c@app.fastmail.com>
Date:   Mon, 14 Aug 2023 10:48:37 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "xingtong.wu" <xingtong_wu@....com>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Wim Van Sebroeck" <wim@...ux-watchdog.org>,
        "Guenter Roeck" <linux@...ck-us.net>,
        "Hans de Goede" <hdegoede@...hat.com>
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Haeussler, Gerd" <gerd.haeussler.ext@...mens.com>,
        "Schaffner, Tobias" <tobias.schaffner@...mens.com>,
        "xingtong.wu" <XingTong.Wu@...mens.com>
Subject: Re: [PATCH] watchdog: simatic: add PCI dependency

On Mon, Aug 14, 2023, at 10:27, xingtong.wu wrote:

>>  
>>  config SIEMENS_SIMATIC_IPC_WDT
>>  	tristate "Siemens Simatic IPC Watchdog"
>> -	depends on SIEMENS_SIMATIC_IPC
>> +	depends on SIEMENS_SIMATIC_IPC && PCI
>
> The SIEMENS_SIMATIC_IPC_WDT does not depends on PCI directly,
> it should depends on P2SB, then P2SB depends on PCI
>
>>  	default y
>>  	select WATCHDOG_CORE
>>  	select P2SB
>
> You can replace the "select" to "depends on" instead.

That would also work, but it's generally best not to mix
'depends on' and 'select' for the same symbol. Changing
all three 'select P2SB' to 'depends on P2SB', or removing
the prompt to turn P2SB itself into a hidden symbol is
probably a good follow-up patch, but I'd keep that separate
from the regression fix.

     Arnd