[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <672725bc-6ebf-0a35-96ab-8862be7de193@redhat.com>
Date: Mon, 14 Aug 2023 10:50:58 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Arnd Bergmann <arnd@...db.de>, "xingtong.wu" <xingtong_wu@....com>,
Arnd Bergmann <arnd@...nel.org>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck <linux@...ck-us.net>,
Andy Shevchenko <andy@...nel.org>
Cc: linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
"Haeussler, Gerd" <gerd.haeussler.ext@...mens.com>,
"Schaffner, Tobias" <tobias.schaffner@...mens.com>,
"xingtong.wu" <XingTong.Wu@...mens.com>
Subject: Re: [PATCH] watchdog: simatic: add PCI dependency
Hi,
On 8/14/23 10:48, Arnd Bergmann wrote:
> On Mon, Aug 14, 2023, at 10:27, xingtong.wu wrote:
>
>>>
>>> config SIEMENS_SIMATIC_IPC_WDT
>>> tristate "Siemens Simatic IPC Watchdog"
>>> - depends on SIEMENS_SIMATIC_IPC
>>> + depends on SIEMENS_SIMATIC_IPC && PCI
>>
>> The SIEMENS_SIMATIC_IPC_WDT does not depends on PCI directly,
>> it should depends on P2SB, then P2SB depends on PCI
>>
>>> default y
>>> select WATCHDOG_CORE
>>> select P2SB
>>
>> You can replace the "select" to "depends on" instead.
>
> That would also work, but it's generally best not to mix
> 'depends on' and 'select' for the same symbol. Changing
> all three 'select P2SB' to 'depends on P2SB', or removing
> the prompt to turn P2SB itself into a hidden symbol is
> probably a good follow-up patch, but I'd keep that separate
> from the regression fix.
Right P2SB would benefit from being changed into a hidden
symbol.
Andy, any comments on making P2SB a hidden symbol ?
Regards,
Hans
>
> Arnd
>
Powered by blists - more mailing lists