linux-kernel - Re: [PATCH] s390/mm: Make virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Aug 2023 15:18:07 +0200
From:   Alexander Gordeev <agordeev@...ux.ibm.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Alexander Potapenko <glider@...gle.com>,
        Marco Elver <elver@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Gerald Schaefer <gerald.schaefer@...ux.ibm.com>,
        Vineeth Vijayan <vneethv@...ux.ibm.com>,
        kasan-dev@...glegroups.com, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/mm: Make virt_to_pfn() a static inline

On Fri, Aug 11, 2023 at 07:49:01PM +0200, Linus Walleij wrote:
> On Fri, Aug 11, 2023 at 3:44 PM Alexander Gordeev
> <agordeev@...ux.ibm.com> wrote:
> 
> > Funnily enough, except drivers/s390/char/vmcp.c none of affected
> > code pieces below is an offender. But anyway, to me it looks like
> > a nice improvement.
> 
> I'm puzzled, vmcp.c is a char * so actually not an offender
> (I am trying to push a version without casting to the compile farm),
> the rest are unsigned long passed to the function which now
> (after my change) has const void * as argument?
> 
> Example:
> 
> > > @@ -90,7 +90,7 @@ static long cmm_alloc_pages(long nr, long *counter,
> 
> unsigned long addr;
> 
> > > +             diag10_range(virt_to_pfn((void *)addr), 1);

I only tried to say that these pieces weren't offenders before
you patch and turned ones after. But that seems like what your
commit message says.

> Yours,
> Linus Walleij

Thanks!