linux-kernel - Re: [v2][PATCH] watchdog: core: stop watchdog when executing poweroff command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac5d44be-0f87-4f13-ba07-fe274ed773fd@roeck-us.net>
Date:   Mon, 14 Aug 2023 06:52:01 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Meng Li <Meng.Li@...driver.com>
Cc:     wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [v2][PATCH] watchdog: core: stop watchdog when executing
 poweroff command

On Mon, Aug 14, 2023 at 05:06:16PM +0800, Meng Li wrote:
> From: Meng Li <meng.li@...driver.com>
> 
> On some platforms, for example, Intel SoC FPGA platform, the watchdog
> is started in u-boot, and so kernel will create a timer and work to
> keep watchdog alive. But when user executes commands "poweroff" or
> "shutdown -h", the system is reset when watchdog triggers timeout even
> if WDOG_STOP_ON_REBOOT is set in watchdog driver. The root cause is
> that the watchdog is not stopped properly because the SYS_POWER_OFF case
> is not supported in notify callback function. So, add this case to stop
> watchdog when executing poweroff command.
> 
> Signed-off-by: Meng Li <Meng.Li@...driver.com>

Makes sense.

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Guenter

> ---
> 
> v2:
>  - fix typos in commit log
> 
> ---
>  drivers/watchdog/watchdog_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/watchdog_core.c b/drivers/watchdog/watchdog_core.c
> index d4c5a736fdcb..5b55ccae06d4 100644
> --- a/drivers/watchdog/watchdog_core.c
> +++ b/drivers/watchdog/watchdog_core.c
> @@ -161,7 +161,7 @@ static int watchdog_reboot_notifier(struct notifier_block *nb,
>  	struct watchdog_device *wdd;
>  
>  	wdd = container_of(nb, struct watchdog_device, reboot_nb);
> -	if (code == SYS_DOWN || code == SYS_HALT) {
> +	if (code == SYS_DOWN || code == SYS_HALT || code == SYS_POWER_OFF) {
>  		if (watchdog_hw_running(wdd)) {
>  			int ret;
>  
> -- 
> 2.17.1
>