linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: add WDT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa699c29-6e63-cbf6-b6ee-1fad76478036@kernel.org>
Date:   Tue, 15 Aug 2023 23:33:16 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Robert Marko <robimarko@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
        wim@...ux-watchdog.org, linux@...ck-us.net, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        quic_saipraka@...cinc.com, linux-arm-msm@...r.kernel.org,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: add WDT

On 15/08/2023 17:38, Robert Marko wrote:
> On Tue, 15 Aug 2023 at 16:40, Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> On 15/08/2023 16:17, Robert Marko wrote:
>>> Add the required DT node for WDT operation.
>>>
>>> Signed-off-by: Robert Marko <robimarko@...il.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/ipq5018.dtsi | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
>>> index 3285c86824cf..168322bfb11c 100644
>>> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
>>> @@ -182,6 +182,13 @@ v2m1: v2m@...0 {
>>>                       };
>>>               };
>>>
>>> +             watchdog: watchdog@...7000 {
>>> +                     compatible = "qcom,apss-wdt-ipq5018", "qcom,kpss-wdt";
>>> +                     interrupts = <GIC_SPI 3 IRQ_TYPE_EDGE_RISING>;
>>
>> I think all GIC_SPI interrupts are level high.
> 
> They are most probably using GIC-500 which supports rising edge or
> active high interrupts.
> Both the older GIC-400 and newer GIC-600 also support the same.
> 
> Vendor DTS indicates this level, IPQ8074 and IPQ6018 which use the
> same core, and it
> seems the same WDT IP use the rising edge IRQ.
> 

That's ok, but now I see missing Cc to DT, so standard message goes:

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least DT list (maybe more), so this won't be tested by
automated tooling. Performing review on untested code might be a waste
of time, thus I will skip this patch entirely till you follow the
process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof