linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: add WDT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOX2RU6HYBzhh0TBdsFj5AJPwqdv2xQ=XsA=L-BaCwNUxTx2Vg@mail.gmail.com>
Date:   Tue, 15 Aug 2023 17:38:36 +0200
From:   Robert Marko <robimarko@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
        wim@...ux-watchdog.org, linux@...ck-us.net, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        quic_saipraka@...cinc.com, linux-arm-msm@...r.kernel.org,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: add WDT

On Tue, 15 Aug 2023 at 16:40, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 15/08/2023 16:17, Robert Marko wrote:
> > Add the required DT node for WDT operation.
> >
> > Signed-off-by: Robert Marko <robimarko@...il.com>
> > ---
> >  arch/arm64/boot/dts/qcom/ipq5018.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > index 3285c86824cf..168322bfb11c 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > @@ -182,6 +182,13 @@ v2m1: v2m@...0 {
> >                       };
> >               };
> >
> > +             watchdog: watchdog@...7000 {
> > +                     compatible = "qcom,apss-wdt-ipq5018", "qcom,kpss-wdt";
> > +                     interrupts = <GIC_SPI 3 IRQ_TYPE_EDGE_RISING>;
>
> I think all GIC_SPI interrupts are level high.

They are most probably using GIC-500 which supports rising edge or
active high interrupts.
Both the older GIC-400 and newer GIC-600 also support the same.

Vendor DTS indicates this level, IPQ8074 and IPQ6018 which use the
same core, and it
seems the same WDT IP use the rising edge IRQ.

>
> > +                     reg = <0x0b017000 0x40>;
>
> Keep the reg as second property.

Ok,
will do.

Regards,
Robert
>
> > +                     clocks = <&sleep_clk>;
> > +             };
>
> Best regards,
> Krzysztof
>