lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aecb4e94bc65928c674b6a083e7fd489.paul@paul-moore.com>
Date:   Tue, 15 Aug 2023 18:09:19 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Atul Kumar Pant <atulpant.linux@...il.com>, eparis@...hat.com
Cc:     Atul Kumar Pant <atulpant.linux@...il.com>, audit@...r.kernel.org,
        linux-kernel@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH v1] kernel: Add space before parenthesis and around '=',  "==" and '<'

On Aug 15, 2023 Atul Kumar Pant <atulpant.linux@...il.com> wrote:
> 
> Fixes following checkpatch.pl issue:
> ERROR: space required before the open parenthesis '('
> ERROR: spaces required around that '='
> ERROR: spaces required around that '<'
> ERROR: spaces required around that '=='
> 
> Signed-off-by: Atul Kumar Pant <atulpant.linux@...il.com>
> ---
>  kernel/acct.c        |  2 +-
>  kernel/auditfilter.c | 16 ++++++++--------
>  kernel/auditsc.c     |  2 +-
>  3 files changed, 10 insertions(+), 10 deletions(-)

I changed the subject line to "audit: add space before parenthesis and
around '=', "==", and '<'" as the "audit:" prefix is more appropriate
and I'm a believer of the Oxford Comma.  Otherwise it looks fine and I
just merged it into audit/next, thanks.

--
paul-moore.com

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ