linux-kernel - Re: [PATCH v1] kernel: Add space before parenthesis and around '=', "==" and '<'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230816025550.GD57274@atom0118>
Date:   Wed, 16 Aug 2023 08:25:50 +0530
From:   Atul Kumar Pant <atulpant.linux@...il.com>
To:     Paul Moore <paul@...l-moore.com>
Cc:     eparis@...hat.com, audit@...r.kernel.org,
        linux-kernel@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH v1] kernel: Add space before parenthesis and around '=',
 "==" and '<'

On Tue, Aug 15, 2023 at 06:09:19PM -0400, Paul Moore wrote:
> On Aug 15, 2023 Atul Kumar Pant <atulpant.linux@...il.com> wrote:
> > 
> > Fixes following checkpatch.pl issue:
> > ERROR: space required before the open parenthesis '('
> > ERROR: spaces required around that '='
> > ERROR: spaces required around that '<'
> > ERROR: spaces required around that '=='
> > 
> > Signed-off-by: Atul Kumar Pant <atulpant.linux@...il.com>
> > ---
> >  kernel/acct.c        |  2 +-
> >  kernel/auditfilter.c | 16 ++++++++--------
> >  kernel/auditsc.c     |  2 +-
> >  3 files changed, 10 insertions(+), 10 deletions(-)
> 
> I changed the subject line to "audit: add space before parenthesis and
> around '=', "==", and '<'" as the "audit:" prefix is more appropriate
> and I'm a believer of the Oxford Comma.  Otherwise it looks fine and I
> just merged it into audit/next, thanks.

	Thank you for your comments. Do I need to change commit message now?

> 
> --
> paul-moore.com