linux-kernel - Re: [PATCH v3 00/14] sysctl: Add a size argument to register functions in sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZNv7wOmUPpCUFnHA@bombadil.infradead.org>
Date:   Tue, 15 Aug 2023 15:27:12 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Joel Granados <joel.granados@...il.com>
Cc:     rds-devel@....oracle.com, "David S. Miller" <davem@...emloft.net>,
        Florian Westphal <fw@...len.de>, willy@...radead.org,
        Jan Karcher <jaka@...ux.ibm.com>,
        Wen Gu <guwen@...ux.alibaba.com>,
        Simon Horman <horms@...ge.net.au>,
        Tony Lu <tonylu@...ux.alibaba.com>, linux-wpan@...r.kernel.org,
        Matthieu Baerts <matthieu.baerts@...sares.net>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        mptcp@...ts.linux.dev, Heiko Carstens <hca@...ux.ibm.com>,
        Stefan Schmidt <stefan@...enfreihafen.org>,
        Will Deacon <will@...nel.org>, Julian Anastasov <ja@....bg>,
        netfilter-devel@...r.kernel.org, Joerg Reuter <jreuter@...na.de>,
        linux-kernel@...r.kernel.org,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        linux-sctp@...r.kernel.org, Xin Long <lucien.xin@...il.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        linux-hams@...r.kernel.org, Vasily Gorbik <gor@...ux.ibm.com>,
        coreteam@...filter.org, Ralf Baechle <ralf@...ux-mips.org>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        keescook@...omium.org, Roopa Prabhu <roopa@...dia.com>,
        David Ahern <dsahern@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Catalin Marinas <catalin.marinas@....com>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Wenjia Zhang <wenjia@...ux.ibm.com>, josh@...htriplett.org,
        linux-fsdevel@...r.kernel.org,
        Alexander Aring <alex.aring@...il.com>,
        Nikolay Aleksandrov <razor@...ckwall.org>,
        netdev@...r.kernel.org,
        Santosh Shilimkar <santosh.shilimkar@...cle.com>,
        linux-s390@...r.kernel.org, Sven Schnelle <svens@...ux.ibm.com>,
        "D. Wythe" <alibuda@...ux.alibaba.com>,
        Eric Dumazet <edumazet@...gle.com>, lvs-devel@...r.kernel.org,
        linux-rdma@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
        Iurii Zaikin <yzaikin@...gle.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        bridge@...ts.linux-foundation.org,
        Karsten Graul <kgraul@...ux.ibm.com>,
        Mat Martineau <martineau@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Joel Granados <j.granados@...sung.com>
Subject: Re: [PATCH v3 00/14] sysctl: Add a size argument to register
 functions in sysctl

On Wed, Aug 09, 2023 at 12:49:52PM +0200, Joel Granados wrote:
> What?
> These commits set things up so we can start removing the sentinel elements.
> They modify sysctl and net_sysctl internals so that registering a ctl_table
> that contains a sentinel gives the same result as passing a table_size
> calculated from the ctl_table array without a sentinel. We accomplish this by
> introducing a table_size argument in the same place where procname is checked
> for NULL. The idea is for it to keep stopping when it hits ->procname == NULL,
> while the sentinel is still present. And when the sentinel is removed, it will
> stop on the table_size (thx to jani.nikula@...ux.intel.com for the discussion
> that led to this). This allows us to remove sentinels from one (or several)
> files at a time.
> 
> These commits are part of a bigger set containing the removal of ctl_table sentinel
> (https://github.com/Joelgranados/linux/tree/tag/sysctl_remove_empty_elem_V3).
> The idea is to make the review process easier by chunking the 65+ commits into
> manageable pieces.

Thanks, I've dropped the old set and merged this updated one onto sysctl-next.

  Luis