linux-kernel - Re: [PATCH 21/25] ASoC: dmaengine: Convert to generic PCM copy ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmxwxsmb.wl-tiwai@suse.de>
Date:   Tue, 15 Aug 2023 16:55:24 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Lars-Peter Clausen <lars@...afoo.de>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 21/25] ASoC: dmaengine: Convert to generic PCM copy ops

On Tue, 15 Aug 2023 16:00:05 +0200,
Andy Shevchenko wrote:
> 
> Can be compressed to a single conditional:
> 
> 	if (is_playback && copy_from_iter(dma_ptr, bytes, buf) != bytes)

I prefer keeping the changes minimalistic in this kind of conversion
unless it becomes too ugly.  Then it's more clearer what's actually
changed.


thanks,

Takashi