[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZNudk4147ByqSNdP@smile.fi.intel.com>
Date: Tue, 15 Aug 2023 18:45:23 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Takashi Iwai <tiwai@...e.de>
Cc: alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
Lars-Peter Clausen <lars@...afoo.de>,
Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 21/25] ASoC: dmaengine: Convert to generic PCM copy ops
On Tue, Aug 15, 2023 at 04:55:24PM +0200, Takashi Iwai wrote:
> On Tue, 15 Aug 2023 16:00:05 +0200,
> Andy Shevchenko wrote:
> >
> > Can be compressed to a single conditional:
> >
> > if (is_playback && copy_from_iter(dma_ptr, bytes, buf) != bytes)
>
> I prefer keeping the changes minimalistic in this kind of conversion
> unless it becomes too ugly. Then it's more clearer what's actually
> changed.
Fine by me!
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists