linux-kernel - Re: [PATCH] selftests/futex: Order calls to futex_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Aug 2023 10:52:34 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     "Nysal Jan K.A" <nysal@...ux.ibm.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Davidlohr Bueso <dave@...olabs.net>,
        André Almeida <andrealmeid@...lia.com>,
        Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/futex: Order calls to futex_lock_pi

On 8/14/23 02:09, Nysal Jan K.A wrote:
> Observed occassional failures in the futex_wait_timeout test:
> 
> ok 1 futex_wait relative succeeds
> ok 2 futex_wait_bitset realtime succeeds
> ok 3 futex_wait_bitset monotonic succeeds
> ok 4 futex_wait_requeue_pi realtime succeeds
> ok 5 futex_wait_requeue_pi monotonic succeeds
> not ok 6 futex_lock_pi realtime returned 0
> ......
> 
> The test expects the child thread to complete some steps before
> the parent thread gets to run. There is an implicit expectation
> of the order of invocation of futex_lock_pi between the child thread
> and the parent thread. Make this order explicit. If the order is
> not met, the futex_lock_pi call in the parent thread succeeds and
> will not timeout.
> 
> Fixes: f4addd54b161 ("selftests: futex: Expand timeout test")
> Signed-off-by: Nysal Jan K.A <nysal@...ux.ibm.com>
> ---

Thank you. Applied to linux-kselftest next for Linux 6.6-rc1.

thanks,
-- Shuah