linux-kernel - Re: [PATCH] tpm_tis: Revert "tpm_tis: Disable interrupts on ThinkPad T490s"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CUU8UN9WOC56.1XCQH80U6OXYC@suppilovahvero>
Date:   Wed, 16 Aug 2023 23:16:08 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "Jerry Snitselaar" <jsnitsel@...hat.com>
Cc:     <linux-integrity@...r.kernel.org>,
        "Jonathan Corbet" <corbet@....net>,
        "Peter Huewe" <peterhuewe@....de>,
        "Jason Gunthorpe" <jgg@...pe.ca>,
        "Richard Cochran" <richardcochran@...il.com>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        "Catalin Marinas" <catalin.marinas@....com>,
        "Randy Dunlap" <rdunlap@...radead.org>,
        "Dave Hansen" <dave.hansen@...ux.intel.com>,
        "Steven Rostedt (Google)" <rostedt@...dmis.org>,
        "Daniel Sneddon" <daniel.sneddon@...ux.intel.com>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] tpm_tis: Revert "tpm_tis: Disable interrupts on
 ThinkPad T490s"

On Tue Aug 15, 2023 at 2:13 AM EEST, Jerry Snitselaar wrote:
> On Mon, Aug 14, 2023 at 07:40:53PM +0300, Jarkko Sakkinen wrote:
> > Since for MMIO driver using FIFO registers, also known as tpm_tis, the
> > default (and tbh recommended) behaviour is now the polling mode, the
> > "tristate" workaround is no longer for benefit.
> > 
> > If someone wants to explicitly enable IRQs for a TPM chip that should be
> > without question allowed. It could very well be a piece hardware in the
> > existing deny list because of e.g. firmware update or something similar.
> > 
> > While at it, document the module parameter, as this was not done in 2006
> > when it first appeared in the mainline.
> > 
> > Link: https://lore.kernel.org/linux-integrity/20201015214430.17937-1-jsnitsel@redhat.com/
> > Link: https://lore.kernel.org/all/1145393776.4829.19.camel@localhost.localdomain/
> > Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>
>
> I was just typing an email to say that it looks like 6aaf663ee04a ("tpm_tis: Opt-in interrupts") will require
> updating tpm_tis_disable_irq(), but you are already dealing with it. :)
>
> Reviewed-by: Jerry Snitselaar <jsnitsel@...hat.com>

Thanks!

BR, Jarkko