linux-kernel - Re: [PATCH] tpm_tis: Revert "tpm_tis: Disable interrupts on ThinkPad T490s"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CUU9233YQJOT.220UJ3EYHDZZ9@suppilovahvero>
Date:   Wed, 16 Aug 2023 23:25:51 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "Randy Dunlap" <rdunlap@...radead.org>,
        <linux-integrity@...r.kernel.org>
Cc:     "Jonathan Corbet" <corbet@....net>,
        "Peter Huewe" <peterhuewe@....de>,
        "Jason Gunthorpe" <jgg@...pe.ca>,
        "Richard Cochran" <richardcochran@...il.com>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        "Catalin Marinas" <catalin.marinas@....com>,
        "Dave Hansen" <dave.hansen@...ux.intel.com>,
        "Steven Rostedt (Google)" <rostedt@...dmis.org>,
        "Daniel Sneddon" <daniel.sneddon@...ux.intel.com>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] tpm_tis: Revert "tpm_tis: Disable interrupts on
 ThinkPad T490s"

On Mon Aug 14, 2023 at 11:00 PM EEST, Randy Dunlap wrote:
> Hi Jarkko,
>
> On 8/14/23 09:40, Jarkko Sakkinen wrote:
> > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> > index 722b6eca2e93..6354aa779178 100644
> > --- a/Documentation/admin-guide/kernel-parameters.txt
> > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > @@ -6340,6 +6340,13 @@
> >  			This will guarantee that all the other pcrs
> >  			are saved.
> >  
> > +	tpm_tis.interrupts= [HW,TPM]
> > +			Enable interrupts for the MMIO based physical layer
> > +			for the FIFO interface. By default it is set to false
> > +			(0). For more information about TPM hardware interfaces
> > +			defined by Trusted Computing Group (TCG) look up to
>
> s/look up to/see/ would be much better IMO.

Agreed, thanks.

BR, Jarkko