linux-kernel - Re: [PATCH v12 1/9] ACPI: Add comments to clarify some #ifdef statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Aug 2023 15:36:46 -0700
From:   Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Mario Limonciello <mario.limonciello@....com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-acpi@...r.kernel.org, Iain Lane <iain@...ngesquash.org.uk>,
        Shyam-sundar S-k <Shyam-sundar.S-k@....com>
Subject: Re: [PATCH v12 1/9] ACPI: Add comments to clarify some #ifdef
 statements


On 8/16/2023 1:41 PM, Mario Limonciello wrote:
> With nested #ifdef statements it's sometimes difficult to tell
> which code goes with which statement.  One comment was wrong,
> so fix it and add another comment to clarify another.

I would explain what is wrong clearly in the commit log. I see this file has
many #ifdefs without comments. Do you want to fix them all?

> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
> v9->v10:
>   * no changes
> ---
>   include/linux/acpi.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index 641dc48439873..0d5277b7c6323 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -1117,10 +1117,10 @@ static inline void arch_reserve_mem_area(acpi_physical_address addr,
>   					  size_t size)
>   {
>   }
> -#endif /* CONFIG_X86 */
> +#endif /* CONFIG_IA64 */
>   #else
>   #define acpi_os_set_prepare_sleep(func, pm1a_ctrl, pm1b_ctrl) do { } while (0)
> -#endif
> +#endif /* CONFIG_ACPI */
>   
>   #if defined(CONFIG_ACPI) && defined(CONFIG_PM)
>   int acpi_dev_suspend(struct device *dev, bool wakeup);