[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b16899c6673a34b69ce5903f5372d0ba@trvn.ru>
Date: Wed, 16 Aug 2023 10:38:29 +0500
From: Nikita Travkin <nikita@...n.ru>
To: Stephan Gerhold <stephan@...hold.net>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, linux-leds@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
"Lin, Meng-Bo" <linmengbo0689@...tonmail.com>
Subject: Re: [PATCH v3 0/3] leds: aw2013: Document interrupt and pull-up
supply
Stephan Gerhold писал(а) 15.08.2023 22:21:
> AW2013 has an optional interrupt pin "INTN" which is used to report
> completion of started operations (e.g. power up or LED breath effects).
> The driver does not use it (yet) but it should be already described for
> completeness inside the DT schema.
>
> Since the interrupt and I2C lines operate in open drain low active mode
> a pull-up supply is needed for correct operation. Unfortunately there
> is no ideal place to describe it in the DT: The pull-up needed for the
> I2C lines could be described on the I2C bus. However, the pull-up
> needed for the interrupt line belongs neither directly to the interrupt
> controller nor to AW2013. Since the AW2013 driver will be typically in
> control of the power management and interrupt masking it makes more
> sense to describe it inside the AW2013 device tree node.
>
Oh indeed, seems like even on the hardware I was initially targeting,
the pull is tied to a regulator, I probably missed it because it was
always on. Thank you both for adding that and fixing up the bindings!
Reviewed-by: Nikita Travkin <nikita@...n.ru>
Nikita
> Changes in v3:
> - Rewrite commit messages based on discussion on v2
> - Also document missing interrupt in DT schema (new patch)
>
> Discussion on v2:
> https://lore.kernel.org/linux-leds/20230321220825.GA1685482-robh@kernel.org/
>
> Signed-off-by: Stephan Gerhold <stephan@...hold.net>
> ---
> Lin, Meng-Bo (1):
> leds: aw2013: Enable pull-up supply for interrupt and I2C
>
> Stephan Gerhold (2):
> dt-bindings: leds: aw2013: Document interrupt
> dt-bindings: leds: Document pull-up supply for interrupt and I2C
>
> .../devicetree/bindings/leds/leds-aw2013.yaml | 13 ++++++++
> drivers/leds/leds-aw2013.c | 36 +++++++++++++---------
> 2 files changed, 35 insertions(+), 14 deletions(-)
> ---
> base-commit: 841165267827955bb3295b066cb6a906ba9265c0
> change-id: 20230815-aw2013-vio-92a4566c5863
>
> Best regards,
Powered by blists - more mailing lists