[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230816093015.GDZNyXJ28y9uspb4Mr@fat_crate.local>
Date: Wed, 16 Aug 2023 11:30:15 +0200
From: Borislav Petkov <bp@...en8.de>
To: Karol Herbst <kherbst@...hat.com>
Cc: linux-kernel@...r.kernel.org, Ben Skeggs <bskeggs@...hat.com>,
Lyude Paul <lyude@...hat.com>, dri-devel@...ts.freedesktop.org,
nouveau@...ts.freedesktop.org, Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH] drm/nouveau/disp: fix use-after-free in error handling
of nouveau_connector_create
On Mon, Aug 14, 2023 at 04:49:32PM +0200, Karol Herbst wrote:
> We can't simply free the connector after calling drm_connector_init on it.
> We need to clean up the drm side first.
>
> It might not fix all regressions from 2b5d1c29f6c4 ("drm/nouveau/disp:
> PIOR DP uses GPIO for HPD, not PMGR AUX interrupts"), but at least it
> fixes a memory corruption in error handling related to that commit.
>
> Link: https://lore.kernel.org/lkml/20230806213107.GFZNARG6moWpFuSJ9W@fat_crate.local/
> Fixes: 95983aea8003 ("drm/nouveau/disp: add connector class")
> Signed-off-by: Karol Herbst <kherbst@...hat.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_connector.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
This one ontop of -rc5 doesn't help, unfortunately.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists