linux-kernel - Re: [PATCH] printk: export symbols for debug modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZNyXdDlruiQAQeMl@alley>
Date:   Wed, 16 Aug 2023 11:31:32 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Enlin Mu <enlinmu@...il.com>
Cc:     Yunlong Xing <yunlong.xing@...soc.com>, senozhatsky@...omium.org,
        rostedt@...dmis.org, john.ogness@...utronix.de,
        linux-kernel@...r.kernel.org, enlin.mu@...soc.com,
        yunlong.xing23@...il.com
Subject: Re: [PATCH] printk: export symbols for debug modules

On Wed 2023-08-16 09:24:29, Enlin Mu wrote:
> Petr Mladek <pmladek@...e.com> 于2023年8月15日周二 21:55写道：
> >
> > On Tue 2023-08-15 10:07:11, Yunlong Xing wrote:
> > > From: Enlin Mu <enlin.mu@...soc.com>
> > >
> > > the module is out-of-tree, it saves kernel logs when panic
> > >
> > > Signed-off-by: Enlin Mu <enlin.mu@...soc.com>
> >
> > I am fine with it. After all, this API seems to here for
> > similar purposes.
> Thanks.
> >
> > Acked-by: Petr Mladek <pmladek@...e.com>
> >
> > Of course, it would be better to maintain the module in upstream.
> > Is there any chance to get it upstream? It seems that it
> > is GPL-compatible so...
> Yes, currently under development. Once the code debugging is stable,
> it will be pushed to the community.

Great.

One more thing which came to my mind.

The log buffer contains the plain text and "id" of the related
metadata. Namely, there is always an "unsigned long" before
each message, see struct prb_data_block.

You might consider using the kmsg_dump API. It has been added
for this purpose. It allows to read and store the messages
one by one. And the messages are formatted the same way
as on console or by dmesg.

The registered dumpers are automatically called in panic().
See kmsg_dump(KMSG_DUMP_PANIC) in panic().

There are few users of this API. Look for kmsg_dump_register()
to get some inspiration.

Best Regards,
Petr