[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6e3i34utxot67jod2opzksdufcnfypycule5kkrcfaezxxvyg4@ixifxnti4wqy>
Date: Wed, 16 Aug 2023 11:31:46 +0200
From: Daniel Wagner <dwagner@...e.de>
To: Sagi Grimberg <sagi@...mberg.me>
Cc: linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-block@...r.kernel.org, Chaitanya Kulkarni <kch@...dia.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>,
Max Gurtovoy <mgurtovoy@...dia.com>,
Hannes Reinecke <hare@...e.de>,
James Smart <jsmart2021@...il.com>,
Bart Van Assche <bvanassche@....org>
Subject: Re: [PATCH blktests v3 00/13] Switch to allowed_host
On Sun, Aug 13, 2023 at 05:59:53PM +0300, Sagi Grimberg wrote:
>
> > Addressed the comments from v2. I also added cleanup code to _nvmet_cleanup() to
> > make sure we do not leak resources when something goes wrong. I run into this
> > while testing and all tests after the first failure failed then.
>
> The name of the patch series suggest that it switches to allowed_hosts
> where it does that in 2 patches 11+12 out of 13 patches. The rest are
> just bug fixes and unifications. It's true that any series will include
> fixes, cleanups and prep patches, but this is too far :)
I see your point. The whole series started smaller, but just grew over
time. I suppose if we agree with the general direction we could just get
the first part done (bug fixes and refactoring).
> I'll let Shinichiro accept as he wish though.
I am fine either way, just let me know what you prefer.
> The cleanups look fine to me.
Thanks for reviewing!
Powered by blists - more mailing lists