[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8f3e12e2-7e0f-3c25-2c7a-7cc7c32b5f36@sionneau.net>
Date: Wed, 16 Aug 2023 11:46:02 +0200
From: Yann Sionneau <yann@...nneau.net>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
Yann Sionneau <ysionneau@...ray.eu>
Subject: Re: [PATCH] i2c: designware: add support for pinctrl for recovery
Le 11/08/2023 à 16:36, Andy Shevchenko a écrit :
> On Fri, Aug 11, 2023 at 03:52:01PM +0200, Yann Sionneau wrote:
>> From: Yann Sionneau <ysionneau@...ray.eu>
>>
>> Currently if the SoC needs pinctrl to switch the scl and sda
> SCL
> SDA
ack
>
>> from hw function to gpio function, the recovery won't work.
> from the I2C
>
> GPIO
ack
>> #include <linux/pm_runtime.h>
>> #include <linux/regmap.h>
>> #include <linux/reset.h>
>> +#include <linux/pinctrl/consumer.h>
> Keep this in order.
Ok
>
> ...
>
>> + rinfo->pinctrl = devm_pinctrl_get(dev->dev);
>> + if (!rinfo->pinctrl || IS_ERR(rinfo->pinctrl)) {
> It's not possible to have it NULL, why a dead code?
Woops, I thought NULL was possible, you are right: it's impossible.
I will also add handling of -EPROBE_DEFER error.
Thanks for the review.
Regards,
--
Yann
Powered by blists - more mailing lists