linux-kernel - Re: [PATCH v15 1/2] thermal: loongson-2: add thermal management support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da3e6348-33e0-aaa9-8f86-4b1ba1504551@linaro.org>
Date:   Wed, 16 Aug 2023 14:46:34 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Yinbo Zhu <zhuyinbo@...ngson.cn>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Jianmin Lv <lvjianmin@...ngson.cn>, wanghongliang@...ngson.cn,
        Liu Peibao <liupeibao@...ngson.cn>,
        loongson-kernel@...ts.loongnix.cn,
        zhanghongchen <zhanghongchen@...ngson.cn>
Subject: Re: [PATCH v15 1/2] thermal: loongson-2: add thermal management
 support

On 20/06/2023 03:29, Yinbo Zhu wrote:
> This patch adds the support for Loongson-2 thermal sensor controller,
> which can support maximum four sensor selectors that corresponding to four
> sets of thermal control registers and one set of sampling register. The
> sensor selector can selector a speific thermal sensor as temperature input.
> The sampling register is used to obtain the temperature in real time, the
> control register GATE field is used to set the threshold of high or low
> temperature, when the input temperature is higher than the high temperature
> threshold or lower than the low temperature threshold, an interrupt will
> occur.
> 
> Signed-off-by: zhanghongchen <zhanghongchen@...ngson.cn>
> Signed-off-by: Yinbo Zhu <zhuyinbo@...ngson.cn>
> ---

[ ... ]

> +	if (devm_thermal_add_hwmon_sysfs(dev, tzd))
> +		dev_warn(dev, "Failed to add hwmon sysfs attributes\n");

[ ... ]

This has been factored out by adding a message directly in 
devm_thermal_add_hwmon_sysfs(), so the test is not needed here neither 
the message.

However, these changes have been long enough on the mailing list and the 
result looks nice.

I can pick this patch and you provide a small patch on top. Or you send 
a V16 with this change. It is your call.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog