[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f33e4fad-6ee0-4892-6eae-0d1308f1166e@infradead.org>
Date: Thu, 17 Aug 2023 10:24:08 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: coolrrsh@...il.com, james.smart@...adcom.com,
ram.vegesna@...adcom.com, jejb@...ux.ibm.com,
martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
target-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v3] scsi: sli4: Remove code duplication
On 8/17/23 04:43, coolrrsh@...il.com wrote:
> From: Rajeshwar R Shinde <coolrrsh@...il.com>
>
> In the function sli_xmit_bls_rsp64_wqe, the 'if' and 'else' conditions
> evaluates the same expression and gives same output. Also, params->s_id
> shall not be equal to U32_MAX. Therefore removing the unused code.
>
> This fixes coccinelle warning such as:
Thanks for that. ^^^^^
> drivers/scsi/elx/libefc_sli/sli4.c:2320:2-4: WARNING: possible
> condition with no effect (if == else)
>
> Signed-off-by: Rajeshwar R Shinde <coolrrsh@...il.com>
Based on feedback from Broadcom people,
Acked-by: Randy Dunlap <rdunlap@...radead.org>
Thanks.
> ---
> v1->v2
> Modified patch and the corrected the warnings using checkpatch.
> v2->v3
> Modified patch details keeping HW descriptor variable.
>
> ---
> drivers/scsi/elx/libefc_sli/sli4.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/elx/libefc_sli/sli4.c b/drivers/scsi/elx/libefc_sli/sli4.c
> index 8f96049f62dd..5e7fb110bc3f 100644
> --- a/drivers/scsi/elx/libefc_sli/sli4.c
> +++ b/drivers/scsi/elx/libefc_sli/sli4.c
> @@ -2317,12 +2317,8 @@ sli_xmit_bls_rsp64_wqe(struct sli4 *sli, void *buf,
> SLI4_GENERIC_CONTEXT_VPI << SLI4_BLS_RSP_WQE_CT_SHFT;
> bls->context_tag = cpu_to_le16(params->vpi);
>
> - if (params->s_id != U32_MAX)
> - bls->local_n_port_id_dword |=
> - cpu_to_le32(params->s_id & 0x00ffffff);
> - else
> - bls->local_n_port_id_dword |=
> - cpu_to_le32(params->s_id & 0x00ffffff);
> + bls->local_n_port_id_dword |=
> + cpu_to_le32(params->s_id & 0x00ffffff);
>
> dw_ridflags = (dw_ridflags & ~SLI4_BLS_RSP_RID) |
> (params->d_id & SLI4_BLS_RSP_RID);
--
~Randy
Powered by blists - more mailing lists