linux-kernel - Re: [PATCH v3] scsi: sli4: Remove code duplication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1msyk6rja.fsf@ca-mkp.ca.oracle.com>
Date:   Mon, 21 Aug 2023 16:59:42 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     coolrrsh@...il.com
Cc:     james.smart@...adcom.com, ram.vegesna@...adcom.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com,
        rdunlap@...radead.org, linux-scsi@...r.kernel.org,
        target-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v3] scsi: sli4: Remove code duplication


> In the function sli_xmit_bls_rsp64_wqe, the 'if' and 'else' conditions
> evaluates the same expression and gives same output. Also,
> params->s_id shall not be equal to U32_MAX. Therefore removing the
> unused code.

Applied to 6.6/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering