linux-kernel - Re: [PATCH v3] scsi: sli4: Remove code duplication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169292577168.789945.14600068133090244401.b4-ty@oracle.com>
Date:   Thu, 24 Aug 2023 21:12:52 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     james.smart@...adcom.com, ram.vegesna@...adcom.com,
        jejb@...ux.ibm.com, rdunlap@...radead.org,
        linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org, coolrrsh@...il.com
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v3] scsi: sli4: Remove code duplication

On Thu, 17 Aug 2023 17:13:01 +0530, coolrrsh@...il.com wrote:

> In the function sli_xmit_bls_rsp64_wqe, the 'if' and 'else' conditions
> evaluates the same expression and gives same output. Also, params->s_id
> shall not be equal to U32_MAX. Therefore removing the unused code.
> 
> This fixes coccinelle warning such as:
> drivers/scsi/elx/libefc_sli/sli4.c:2320:2-4: WARNING: possible
> condition with no effect (if == else)
> 
> [...]

Applied to 6.6/scsi-queue, thanks!

[1/1] scsi: sli4: Remove code duplication
      https://git.kernel.org/mkp/scsi/c/2d6f70fe175e

-- 
Martin K. Petersen	Oracle Linux Engineering