linux-kernel - Re: [PATCH v2] scsi: fcoe: Fix potential deadlock on &fip->ctlr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169292577171.789945.18412382770051459269.b4-ty@oracle.com>
Date:   Thu, 24 Aug 2023 21:12:53 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     hare@...e.de, jejb@...ux.ibm.com, bigeasy@...utronix.de,
        dave@...olabs.net, satishkh@...co.com, sebaddel@...co.com,
        kartilak@...co.com, Chengfeng Ye <dg573847474@...il.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock

On Thu, 17 Aug 2023 07:47:08 +0000, Chengfeng Ye wrote:

> There is a long call chain that &fip->ctlr_lock is acquired by isr
> fnic_isr_msix_wq_copy() under hard irq context. Thus other process
> context code acquiring the lock should disable irq, otherwise
> deadlock could happen if the irq preempt the execution while the
> lock is held in process context on the same CPU.
> 
> [ISR]
> fnic_isr_msix_wq_copy()
>  -> fnic_wq_copy_cmpl_handler()
>  -> fnic_fcpio_cmpl_handler()
>  -> fnic_fcpio_flogi_reg_cmpl_handler()
>  -> fnic_flush_tx()
>  -> fnic_send_frame()
>  -> fcoe_ctlr_els_send()
>  -> spin_lock_bh(&fip->ctlr_lock)
> 
> [...]

Applied to 6.6/scsi-queue, thanks!

[1/1] scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock
      https://git.kernel.org/mkp/scsi/c/1a1975551943

-- 
Martin K. Petersen	Oracle Linux Engineering