linux-kernel - RE: [PATCH] wifi: rtw88: usb: kill and free rx urbs on probe failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b4b4228bfd140119665417137a087ea@realtek.com>
Date:   Fri, 25 Aug 2023 01:13:08 +0000
From:   Ping-Ke Shih <pkshih@...ltek.com>
To:     Sascha Hauer <s.hauer@...gutronix.de>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kalle Valo <kvalo@...nel.org>,
        Ilgaz Öcal <ilgaz@...az.gen.tr>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: RE: [PATCH] wifi: rtw88: usb: kill and free rx urbs on probe failure



> -----Original Message-----
> From: Sascha Hauer <s.hauer@...gutronix.de>
> Sent: Wednesday, August 23, 2023 3:50 PM
> To: linux-wireless@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org; Ping-Ke Shih <pkshih@...ltek.com>; Kalle Valo <kvalo@...nel.org>; Ilgaz
> Öcal <ilgaz@...az.gen.tr>; kernel@...gutronix.de
> Subject: [PATCH] wifi: rtw88: usb: kill and free rx urbs on probe failure
> 
> After rtw_usb_alloc_rx_bufs() has been called rx urbs have been
> allocated and must be freed in the error path. After rtw_usb_init_rx()
> has been called they are submitted, so they also must be killed.
> 
> Add these forgotten steps to the probe error path.
> 
> Besides the lost memory this also fixes a problem when the driver
> fails to download the firmware in rtw_chip_info_setup(). In this
> case it can happen that the completion of the rx urbs handler runs
> at a time when we already freed our data structures resulting in
> a kernel crash.
> 
> fixes: a82dfd33d1237 ("wifi: rtw88: Add common USB chip support")
> Cc: stable@...r.kernel.org
> Reported-by: Ilgaz Öcal <ilgaz@...az.gen.tr>
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>