linux-kernel - Re: wifi: rtw88: usb: kill and free rx urbs on probe failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Aug 2023 10:02:35 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Sascha Hauer <s.hauer@...gutronix.de>
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Ilgaz Öcal <ilgaz@...az.gen.tr>,
        kernel@...gutronix.de
Subject: Re: wifi: rtw88: usb: kill and free rx urbs on probe failure

Sascha Hauer <s.hauer@...gutronix.de> wrote:

> After rtw_usb_alloc_rx_bufs() has been called rx urbs have been
> allocated and must be freed in the error path. After rtw_usb_init_rx()
> has been called they are submitted, so they also must be killed.
> 
> Add these forgotten steps to the probe error path.
> 
> Besides the lost memory this also fixes a problem when the driver
> fails to download the firmware in rtw_chip_info_setup(). In this
> case it can happen that the completion of the rx urbs handler runs
> at a time when we already freed our data structures resulting in
> a kernel crash.
> 
> Fixes: a82dfd33d123 ("wifi: rtw88: Add common USB chip support")
> Cc: stable@...r.kernel.org
> Reported-by: Ilgaz Öcal <ilgaz@...az.gen.tr>
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> Acked-by: Larry Finger <Larry.Finger@...inger.net>
> Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

Patch applied to wireless-next.git, thanks.

290564367ab7 wifi: rtw88: usb: kill and free rx urbs on probe failure

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230823075021.588596-1-s.hauer@pengutronix.de/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches