[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a5ef22bc-2457-5eef-7cff-529711c5c242@oss.nxp.com>
Date: Fri, 25 Aug 2023 13:01:08 +0300
From: "Radu Pirea (OSS)" <radu-nicolae.pirea@....nxp.com>
To: Sabrina Dubroca <sd@...asysnail.net>
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, richardcochran@...il.com,
sebastian.tobuschat@....com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [RFC net-next v2 2/5] net: macsec: introduce mdo_insert_tx_tag
On 24.08.2023 17:54, Sabrina Dubroca wrote:
> 2023-08-24, 12:16:12 +0300, Radu Pirea (NXP OSS) wrote:
>
>> +
>> + if (macsec_is_offloaded(macsec)) {
>
> Shouldn't that whole adjustment (in both directions) depend on
> ->insert_tx_tag?
I asked myself the same thing and the answer was "It depends". This
adjustment can be restricted only to the offloaded MACsec devs that
require a special TX tag. However, the offloaded MACsec devs do not need
additional headroom/tailroom.
>> +
>> + if (!macsec->insert_tx_tag)
>> + return skb;
>
> I think it would look a bit nicer if this test was moved out, before
> calling insert_tx_tag(). Then if we call insert_tx_tag(), we know we
> have to insert it.
>
I expected this suggestion :)
--
Radu P.
Powered by blists - more mailing lists