linux-kernel - Re: [PATCH v2] scsi: fcoe: Fix potential deadlock on &fip->ctlr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1h6os6rdl.fsf@ca-mkp.ca.oracle.com>
Date:   Mon, 21 Aug 2023 17:02:41 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Chengfeng Ye <dg573847474@...il.com>
Cc:     hare@...e.de, jejb@...ux.ibm.com, martin.petersen@...cle.com,
        bigeasy@...utronix.de, dave@...olabs.net, satishkh@...co.com,
        sebaddel@...co.com, kartilak@...co.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock


Chengfeng,

> There is a long call chain that &fip->ctlr_lock is acquired by isr
> fnic_isr_msix_wq_copy() under hard irq context. Thus other process
> context code acquiring the lock should disable irq, otherwise deadlock
> could happen if the irq preempt the execution while the lock is held
> in process context on the same CPU.

Applied to 6.6/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering