linux-kernel - Re: [PATCH RESEND] scsi: fcoe: Fix potential deadlock on &fip->ctlr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230817065211.ajz8zcev@linutronix.de>
Date:   Thu, 17 Aug 2023 08:52:11 +0200
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Chengfeng Ye <dg573847474@...il.com>
Cc:     hare@...e.de, jejb@...ux.ibm.com, martin.petersen@...cle.com,
        dave@...olabs.net, satishkh@...co.com, sebaddel@...co.com,
        kartilak@...co.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] scsi: fcoe: Fix potential deadlock on
 &fip->ctlr_lock

On 2023-08-16 15:55:24 [+0000], Chengfeng Ye wrote:
> These flaws were found by an experimental static analysis tool I am
> developing for irq-related deadlock.

So you did not use lockdep or is the code path so unlikely that nobody
stumbled upon it before?

> The patch fix the potential deadlocks by spin_lock_irqsave() to
> disable hard irq.

Shouldn't this have

Fixes: 794d98e77f590 ("[SCSI] libfcoe: retry rejected FLOGI to another FCF if possible")

?

> Signed-off-by: Chengfeng Ye <dg573847474@...il.com>

Reviewed-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Sebastian