linux-kernel - Re: [PATCH RESEND] scsi: fcoe: Fix potential deadlock on &fip->ctlr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAo+4rVzgdAsbj7Nrd32BFBsGY1YBBh18v9vF0xH2jcWoPgivA@mail.gmail.com>
Date:   Thu, 17 Aug 2023 15:48:19 +0800
From:   Chengfeng Ye <dg573847474@...il.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     hare@...e.de, jejb@...ux.ibm.com, martin.petersen@...cle.com,
        dave@...olabs.net, satishkh@...co.com, sebaddel@...co.com,
        kartilak@...co.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock

> So you did not use lockdep or is the code path so unlikely that nobody
> stumbled upon it before?

I think so, the lock acquisition inside the interrupt is guarded by an
"unlikely"
if-branch condition inside fnic_send_frame(), so it happens that no one has
encountered the problem so far by using lockdep.


> Fixes: 794d98e77f590 ("[SCSI] libfcoe: retry rejected FLOGI to another FCF if possible")

Just sent v2 patch to add the fixes tag


Thanks for the review,
Chengfeng