[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <78348c02-6f5a-2d25-b417-089346f4d412@linux.alibaba.com>
Date: Thu, 17 Aug 2023 17:25:13 +0800
From: Guangguan Wang <guangguan.wang@...ux.alibaba.com>
To: Jan Karcher <jaka@...ux.ibm.com>, wenjia@...ux.ibm.com,
kgraul@...ux.ibm.com, tonylu@...ux.alibaba.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com
Cc: horms@...nel.org, alibuda@...ux.alibaba.com,
guwen@...ux.alibaba.com, linux-s390@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 4/6] net/smc: support max connections per lgr
negotiation
On 2023/8/17 14:42, Jan Karcher wrote:
>
>
> On 16/08/2023 10:33, Guangguan Wang wrote:
...
>> @@ -1163,6 +1173,11 @@ int smc_clc_srv_v2x_features_validate(struct smc_clc_msg_proposal *pclc,
>> {
>> struct smc_clc_v2_extension *pclc_v2_ext;
>> + /* default max conn is SMC_CONN_PER_LGR_MAX(255),
>> + * which is the default value in smc v1 and v2.0.
>> + */
>
> I'm afraid this comment is not going to age well. You already put this to the define itself so i plea to remove it here.
>
> Thank you.
> - Jan
>
Get it, Thanks.
Powered by blists - more mailing lists