linux-kernel - Re: [PATCH 28/36] tty: propagate u8 data to tty_operations::put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Aug 2023 12:55:06 +0200
From:   Alexander Gordeev <agordeev@...ux.ibm.com>
To:     "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc:     gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Karsten Keil <isdn@...ux-pingi.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Mathias Nyman <mathias.nyman@...el.com>
Subject: Re: [PATCH 28/36] tty: propagate u8 data to
 tty_operations::put_char()

On Thu, Aug 10, 2023 at 11:15:02AM +0200, Jiri Slaby (SUSE) wrote:
...
>  drivers/s390/char/con3215.c            | 2 +-
>  drivers/s390/char/con3270.c            | 2 +-
>  drivers/s390/char/sclp_tty.c           | 6 +++---
>  drivers/s390/char/sclp_vt220.c         | 2 +-
...
> diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
> index 16b6f430dfd3..8bbce6a4d7f5 100644
> --- a/drivers/s390/char/con3215.c
> +++ b/drivers/s390/char/con3215.c
> @@ -1030,7 +1030,7 @@ static int tty3215_write(struct tty_struct *tty, const u8 *buf, int count)
>  /*
>   * Put character routine for 3215 ttys
>   */
> -static int tty3215_put_char(struct tty_struct *tty, unsigned char ch)
> +static int tty3215_put_char(struct tty_struct *tty, u8 ch)
>  {
>  	struct raw3215_info *raw = tty->driver_data;
>  
> diff --git a/drivers/s390/char/con3270.c b/drivers/s390/char/con3270.c
> index 123524bff734..6374555a0937 100644
> --- a/drivers/s390/char/con3270.c
> +++ b/drivers/s390/char/con3270.c
> @@ -1821,7 +1821,7 @@ static int tty3270_write(struct tty_struct *tty, const u8 *buf, int count)
>  /*
>   * Put single characters to the ttys character buffer
>   */
> -static int tty3270_put_char(struct tty_struct *tty, unsigned char ch)
> +static int tty3270_put_char(struct tty_struct *tty, u8 ch)
>  {
>  	struct tty3270 *tp;
>  
> diff --git a/drivers/s390/char/sclp_tty.c b/drivers/s390/char/sclp_tty.c
> index cc0f6a97124e..831a8c7cacc2 100644
> --- a/drivers/s390/char/sclp_tty.c
> +++ b/drivers/s390/char/sclp_tty.c
> @@ -48,7 +48,7 @@ static struct sclp_buffer *sclp_ttybuf;
>  static struct timer_list sclp_tty_timer;
>  
>  static struct tty_port sclp_port;
> -static unsigned char sclp_tty_chars[SCLP_TTY_BUF_SIZE];
> +static u8 sclp_tty_chars[SCLP_TTY_BUF_SIZE];
>  static unsigned short int sclp_tty_chars_count;
>  
>  struct tty_driver *sclp_tty_driver;
> @@ -168,7 +168,7 @@ sclp_tty_timeout(struct timer_list *unused)
>  /*
>   * Write a string to the sclp tty.
>   */
> -static int sclp_tty_write_string(const unsigned char *str, int count, int may_fail)
> +static int sclp_tty_write_string(const u8 *str, int count, int may_fail)
>  {
>  	unsigned long flags;
>  	void *page;
> @@ -250,7 +250,7 @@ sclp_tty_write(struct tty_struct *tty, const u8 *buf, int count)
>   * sclp_write() without final '\n' - will be written.
>   */
>  static int
> -sclp_tty_put_char(struct tty_struct *tty, unsigned char ch)
> +sclp_tty_put_char(struct tty_struct *tty, u8 ch)
>  {
>  	sclp_tty_chars[sclp_tty_chars_count++] = ch;
>  	if (ch == '\n' || sclp_tty_chars_count >= SCLP_TTY_BUF_SIZE) {
> diff --git a/drivers/s390/char/sclp_vt220.c b/drivers/s390/char/sclp_vt220.c
> index 44974d801c1e..e148350c1e2c 100644
> --- a/drivers/s390/char/sclp_vt220.c
> +++ b/drivers/s390/char/sclp_vt220.c
> @@ -579,7 +579,7 @@ sclp_vt220_close(struct tty_struct *tty, struct file *filp)
>   * done stuffing characters into the driver.
>   */
>  static int
> -sclp_vt220_put_char(struct tty_struct *tty, unsigned char ch)
> +sclp_vt220_put_char(struct tty_struct *tty, u8 ch)
>  {
>  	return __sclp_vt220_write(&ch, 1, 0, 0, 1);
>  }

For s390 part:

Acked-by: Alexander Gordeev <agordeev@...ux.ibm.com>

Thanks!