linux-kernel - Re: [PATCH 16/36] tty: use u8 for chars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZPDc6P2tp4lQzrKA@smile.fi.intel.com>
Date:   Thu, 31 Aug 2023 21:33:12 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     "Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        William Hubbs <w.d.hubbs@...il.com>,
        Chris Brannon <chris@...-brannons.com>,
        Kirk Reiser <kirk@...sers.ca>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Arnd Bergmann <arnd@...db.de>, Max Staudt <max@...as.org>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Dario Binacchi <dario.binacchi@...rulasolutions.com>,
        Andreas Koensgen <ajk@...nets.uni-bremen.de>,
        Jeremy Kerr <jk@...econstruct.com.au>,
        Matt Johnston <matt@...econstruct.com.au>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Peter Ujfalusi <peter.ujfalusi@...il.com>
Subject: Re: [PATCH 16/36] tty: use u8 for chars

On Fri, Aug 11, 2023 at 01:28:56PM +0300, Ilpo Järvinen wrote:
> On Thu, 10 Aug 2023, Jiri Slaby (SUSE) wrote:

...

> > @@ -22,9 +22,9 @@ struct tty_buffer {
> >  	unsigned long data[];
> >  };
> >  
> > -static inline unsigned char *char_buf_ptr(struct tty_buffer *b, int ofs)
> > +static inline u8 *char_buf_ptr(struct tty_buffer *b, int ofs)
> >  {
> > -	return ((unsigned char *)b->data) + ofs;
> > +	return ((u8 *)b->data) + ofs;
> >  }
> 
> Any particular reason why b->data is left unsigned long?

It might be the performance issue due to unaligned accesses on some
architectures. But I'm just speculating...

-- 
With Best Regards,
Andy Shevchenko