linux-kernel - Re: [GIT PULL] one more nfsd fix for 6.5-rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whnm7RyZfy2s4BOdkMz=dMrPJRnH79KVH8rtC1vrV9G1w@mail.gmail.com>
Date:   Thu, 17 Aug 2023 16:49:37 +0200
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Chuck Lever III <chuck.lever@...cle.com>
Cc:     Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Jeff Layton <jlayton@...nel.org>
Subject: Re: [GIT PULL] one more nfsd fix for 6.5-rc

On Thu, 17 Aug 2023 at 16:11, Chuck Lever III <chuck.lever@...cle.com> wrote:
>
>   https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git tags/nfsd-6.5-4

I've pulled this, but...

> Jeff Layton (1):
>       sunrpc: set the bv_offset of first bvec in svc_tcp_sendmsg

.. what an odd place to set bv_offset that is.

I'm sure it's right, but it really smells odd to set that initial
offset not when the bvec is created, but long afterwards, just before
it is used.

Is there some reason why 'bv_offset' isn't initialized when the bvec is created?

             Linus