linux-kernel - Re: [GIT PULL] one more nfsd fix for 6.5-rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27B358DC-D32E-46F5-B611-A179C6AB2B90@oracle.com>
Date:   Thu, 17 Aug 2023 14:55:08 +0000
From:   Chuck Lever III <chuck.lever@...cle.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
CC:     Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Jeff Layton <jlayton@...nel.org>
Subject: Re: [GIT PULL] one more nfsd fix for 6.5-rc



> On Aug 17, 2023, at 10:49 AM, Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> 
> On Thu, 17 Aug 2023 at 16:11, Chuck Lever III <chuck.lever@...cle.com> wrote:
>> 
>>  https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git tags/nfsd-6.5-4
> 
> I've pulled this, but...
> 
>> Jeff Layton (1):
>>      sunrpc: set the bv_offset of first bvec in svc_tcp_sendmsg
> 
> .. what an odd place to set bv_offset that is.
> 
> I'm sure it's right, but it really smells odd to set that initial
> offset not when the bvec is created, but long afterwards, just before
> it is used.
> 
> Is there some reason why 'bv_offset' isn't initialized when the bvec is created?

Yes:

https://lore.kernel.org/linux-nfs/7c9421cc4b92dee76cc7560c50a4a0ab3fb1ef0d.camel@kernel.org/T/#t

But also note that this fix will get replaced in v6.6:

https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/commit/?h=nfsd-next&id=383bc8bbc3e61d185ff8082cad2da831f158be4a

I just wanted to ensure that v6.5 wasn't broken. It's a little late in the
cycle to apply 383bc8bbc.

If you feel it's appropriate, perhaps you could add a link to the above
lore discussion to the fix... but as the fix is temporary, perhaps not
worth the bother.


--
Chuck Lever