linux-kernel - Re: [PATCH v3 1/4] dt-bindings: net: Add FSD EQoS device tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230817145408.GA953517-robh@kernel.org>
Date:   Thu, 17 Aug 2023 09:54:08 -0500
From:   Rob Herring <robh@...nel.org>
To:     Sriranjani P <sriranjani.p@...sung.com>
Cc:     edumazet@...gle.com, linux-kernel@...r.kernel.org,
        alexandre.torgue@...s.st.com, ravi.patel@...sung.com,
        alim.akhtar@...sung.com, linux-samsung-soc@...r.kernel.org,
        linux-fsd@...la.com, conor+dt@...nel.org,
        mcoquelin.stm32@...il.com, kuba@...nel.org, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, pabeni@...hat.com,
        pankaj.dubey@...sung.com, richardcochran@...il.com,
        krzysztof.kozlowski+dt@...aro.org, joabreu@...opsys.com,
        devicetree@...r.kernel.org, davem@...emloft.net,
        swathi.ks@...sung.com
Subject: Re: [PATCH v3 1/4] dt-bindings: net: Add FSD EQoS device tree
 bindings

On Wed, Aug 16, 2023 at 11:06:51AM +0530, Sriranjani P wrote:
> 
> 
> > -----Original Message-----
> > From: Rob Herring [mailto:robh@...nel.org]
> > Sent: 14 August 2023 19:03
> > To: Sriranjani P <sriranjani.p@...sung.com>
> > Cc: edumazet@...gle.com; linux-kernel@...r.kernel.org;
> > alexandre.torgue@...s.st.com; ravi.patel@...sung.com;
> > alim.akhtar@...sung.com; linux-samsung-soc@...r.kernel.org; linux-
> > fsd@...la.com; conor+dt@...nel.org; mcoquelin.stm32@...il.com;
> > kuba@...nel.org; netdev@...r.kernel.org; linux-arm-
> > kernel@...ts.infradead.org; pabeni@...hat.com; robh+dt@...nel.org;
> > pankaj.dubey@...sung.com; richardcochran@...il.com;
> > krzysztof.kozlowski+dt@...aro.org; joabreu@...opsys.com;
> > devicetree@...r.kernel.org; davem@...emloft.net;
> > swathi.ks@...sung.com
> > Subject: Re: [PATCH v3 1/4] dt-bindings: net: Add FSD EQoS device tree
> > bindings
> > 
> > 
> > On Mon, 14 Aug 2023 16:55:36 +0530, Sriranjani P wrote:
> > > Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
> > > Ethernet YAML schema to enable the DT validation.
> > >
> > > Signed-off-by: Pankaj Dubey <pankaj.dubey@...sung.com>
> > > Signed-off-by: Ravi Patel <ravi.patel@...sung.com>
> > > Signed-off-by: Swathi K S <swathi.ks@...sung.com>
> > > Signed-off-by: Sriranjani P <sriranjani.p@...sung.com>
> > > ---
> > >  .../devicetree/bindings/net/snps,dwmac.yaml   |   5 +-
> > >  .../devicetree/bindings/net/tesla,ethqos.yaml | 114
> > > ++++++++++++++++++
> > >  2 files changed, 117 insertions(+), 2 deletions(-)  create mode
> > > 100644 Documentation/devicetree/bindings/net/tesla,ethqos.yaml
> > >
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m
> > dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-
> > ci/linux/Documentation/devicetree/bindings/net/tesla,ethqos.yaml:
> > properties:clock-names: {'minItems': 5, 'maxItems': 10, 'items': [{'const':
> > 'ptp_ref'}, {'const': 'master_bus'}, {'const': 'slave_bus'}, {'const': 'tx'}, {'const':
> > 'rx'}, {'const': 'master2_bus'}, {'const': 'slave2_bus'}, {'const':
> > 'eqos_rxclk_mux'}, {'const': 'eqos_phyrxclk'}, {'const':
> > 'dout_peric_rgmii_clk'}]} should not be valid under {'required': ['maxItems']}
> > 	hint: "maxItems" is not needed with an "items" list
> > 	from schema $id: https://protect2.fireeye.com/v1/url?k=f50e335d-
> > aa950a44-f50fb812-000babff3793-de26ea17ef025418&q=1&e=897786e4-
> > 5f9b-40d8-8a7f-399cb69c7ee8&u=http%3A%2F%2Fdevicetree.org%2Fmeta-
> > schemas%2Fitems.yaml%23
> > Documentation/devicetree/bindings/net/tesla,ethqos.example.dtb:
> > /example-0/ethernet@...00000: failed to match any schema with
> > compatible: ['tesla,dwc-qos-ethernet-4.21']
> > 
> 
> Thanks for review. Will fix this in v4.

It's not a review. It's an automated reply running what you should have 
run yourself...

> 
> > doc reference errors (make refcheckdocs):
> > 
> > See https://protect2.fireeye.com/v1/url?k=ccb7f6d0-932ccfc9-ccb67d9f-
> > 000babff3793-2137ac63fe6ddef8&q=1&e=897786e4-5f9b-40d8-8a7f-
> > 399cb69c7ee8&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fdev
> > icetree-bindings%2Fpatch%2F20230814112539.70453-2-
> > sriranjani.p%40samsung.com
> > 
> > The base for the series is generally the latest rc1. A different dependency
> > should be noted in *this* patch.
> > 
> 
> Sorry, I could not get this comment, can you elaborate this. 

The automated tests apply patches to the latest rc1 tag. Patches which 
apply, but have some other dependency may have warnings. If you have 
such a dependency, you should note it in the patch (below the '---').

Rob